earl-warren/end-to-end
2
1
Fork 0
Code Issues 3 Pull requests 13 Actions Packages Projects Releases Wiki Activity

add pprof upload test #141

Merged
thefox merged 5 commits from refs/pull/141/head into main 2024-04-27 08:53:37 +00:00
Conversation 4 Commits 5 Files changed 3 +41
thefox commented 2024-03-31 20:51:52 +00:00 (Migrated from code.forgejo.org)
Copy link

Tests if pyroscope accepts generated pprof files

related to: https://codeberg.org/forgejo/forgejo/pulls/2933

Tests if pyroscope accepts generated pprof files related to: https://codeberg.org/forgejo/forgejo/pulls/2933
earl-warren (Migrated from code.forgejo.org) reviewed 2024-03-31 21:42:09 +00:00
upgrade/test_pprof_upload.sh
earl-warren (Migrated from code.forgejo.org) commented 2024-03-31 21:42:09 +00:00
Copy link

start 8.0-dev

this will start a forgejo binary built from the tip of the forgejo branch. Or from a forgejo pull request, when the tests are triggered by a pull request.

start 8.0-dev this will start a forgejo binary built from the tip of the forgejo branch. Or from a forgejo pull request, when the tests are triggered by a pull request.
earl-warren (Migrated from code.forgejo.org) reviewed 2024-03-31 21:44:01 +00:00
upgrade/test_pprof_upload.sh
earl-warren (Migrated from code.forgejo.org) commented 2024-03-31 21:44:02 +00:00
Copy link

FORGEJO_URL="http://$HOST_PORT"

as set in https://code.forgejo.org/forgejo/end-to-end/src/branch/main/lib/lib.sh#L30

FORGEJO_URL="http://$HOST_PORT" as set in https://code.forgejo.org/forgejo/end-to-end/src/branch/main/lib/lib.sh#L30
earl-warren (Migrated from code.forgejo.org) commented 2024-03-31 23:23:54 +00:00
Copy link

Switched to the http://$IP:6060 as pprof does not listen on the same port as everything else.

Switched to the `http://$IP:6060` as pprof does not listen on the same port as everything else.
earl-warren commented 2024-03-31 21:46:56 +00:00 (Migrated from code.forgejo.org)
Copy link

For a faster debug loop you can run that manually as described in the README. If the instructions are not clear, please ask: you are the third person to use them, me included.

For a faster debug loop you can run that manually as described in the README. If the instructions are not clear, please ask: you are the third person to use them, me included.
thefox commented 2024-04-01 00:30:40 +00:00 (Migrated from code.forgejo.org)
Copy link

hm... It seems it's not listening on the endpoint despite it having the flag set. Any ideas as to why?

hm... It seems it's not listening on the endpoint despite it having the flag set. Any ideas as to why?
earl-warren commented 2024-04-01 06:04:04 +00:00 (Migrated from code.forgejo.org)
Copy link

hm... It seems it's not listening on the endpoint despite it having the flag set. Any ideas as to why?

Not from the top of my head. That's where local debug will help. For a faster CI round trip I suggest you remove the jobs that are unrelated to what you're after, in a separate commit that you can remove when it is ready.

Note that the actions failure is unrelated: it is a transient error.

> hm... It seems it's not listening on the endpoint despite it having the flag set. Any ideas as to why? Not from the top of my head. That's where local debug will help. For a faster CI round trip I suggest you remove the jobs that are unrelated to what you're after, in a separate commit that you can remove when it is ready. Note that the actions failure is unrelated: it is a transient error.
thefox commented 2024-04-01 15:52:20 +00:00 (Migrated from code.forgejo.org)
Copy link

Well... after looking into this I still have no idea what is going wrong. I tried starting it in incus (debian bullseye image) but haven't managed to get it working...

Well... after looking into this I still have no idea what is going wrong. I tried starting it in incus (debian bullseye image) but haven't managed to get it working...
👀 1
earl-warren (Migrated from code.forgejo.org) reviewed 2024-04-02 18:11:21 +00:00
upgrade/test-pprof-upload.sh
earl-warren (Migrated from code.forgejo.org) commented 2024-04-02 18:11:21 +00:00
Copy link

start 8.0-test

should be all you need to change now to verify it works since your patch landed yesterday and 8.0-test contains it.

`start 8.0-test` should be all you need to change now to verify it works since your patch landed yesterday and `8.0-test` contains it.
earl-warren (Migrated from code.forgejo.org) approved these changes 2024-04-02 18:54:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
l1

l1

  
l2
No labels
l1
l2
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: earl-warren/end-to-end#141
No description provided.
Delete branch "refs/pull/141/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?