earl-warren/end-to-end
2
1
Fork 0
Code Issues 3 Pull requests 13 Actions Packages Projects Releases Wiki Activity

Add E2E test for Alpine package with noarch architecture #110

Merged
twenty-panda merged 2 commits from refs/pull/110/head into main 2024-04-27 08:53:41 +00:00
Conversation 0 Commits 2 Files changed 15 +158 -6
twenty-panda commented 2024-03-17 19:03:02 +00:00 (Migrated from code.forgejo.org)
Copy link

Porting https://code.forgejo.org/forgejo/end-to-end/pulls/75 to the refactor

Also adds a step in the workflow that shows the full logs for forensic analysis but also for human verification of the output, in case there is a doubt of a false positive.

image

Porting https://code.forgejo.org/forgejo/end-to-end/pulls/75 to the refactor Also adds a step in the workflow that shows the full logs for forensic analysis but also for human verification of the output, in case there is a doubt of a false positive. ![image](/attachments/69fef366-542e-482c-b157-854f433feb37)
Xinayder (Migrated from code.forgejo.org) reviewed 2024-03-17 20:31:01 +00:00
earl-warren (Migrated from code.forgejo.org) approved these changes 2024-03-17 20:45:07 +00:00
earl-warren (Migrated from code.forgejo.org) left a comment
Copy link

It looks good. I have no Alpine expertise but the test is copy/pasted from @Xinayder PR and I assume it is good. In theory testing against 7.0-dev should also be good for when a PR is made to Forgejo and the run-end-to-end-test label is set. This simplifies the workflow when working on two separate PRs (one on Forgejo the other in end-to-end)

It looks good. I have no Alpine expertise but the test is copy/pasted from @Xinayder PR and I assume it is good. In theory testing against 7.0-dev should also be good for when a PR is made to Forgejo and the `run-end-to-end-test` label is set. This simplifies the workflow when working on two separate PRs (one on Forgejo the other in end-to-end)
Sign in to join this conversation.
Reviewers
No reviewers
Xinayder
earl-warren
Labels
Clear labels   
l1

l1

  
l2
No labels
l1
l2
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: earl-warren/end-to-end#110
No description provided.
Delete branch "refs/pull/110/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?