earl-warren/end-to-end
2
1
Fork 0
Code Issues 3 Pull requests 13 Actions Packages Projects Releases Wiki Activity

unify packages & upgrades #107

Merged
twenty-panda merged 8 commits from refs/pull/107/head into main 2024-04-27 08:53:41 +00:00
Conversation 4 Commits 8 Files changed 10 +367 -459
twenty-panda commented 2024-03-15 05:33:54 +00:00 (Migrated from code.forgejo.org)
Copy link

packages must also be tested for upgrades, they need the same range of Forgejo versions to test against. Group them together instead of keeping them appart.

packages must also be tested for upgrades, they need the same range of Forgejo versions to test against. Group them together instead of keeping them appart.
earl-warren (Migrated from code.forgejo.org) reviewed 2024-03-15 12:48:42 +00:00
earl-warren (Migrated from code.forgejo.org) left a comment
Copy link

Much needed refactor. The initial implementation of the package tests should have gone this way from the start: it duplicated way too much.

Much needed refactor. The initial implementation of the package tests should have gone this way from the start: it duplicated way too much.
lib/lib.sh
earl-warren (Migrated from code.forgejo.org) commented 2024-03-15 12:48:42 +00:00
Copy link

Is it really necessary for this lib.sh to be executable? I don't see why.

Is it really necessary for this lib.sh to be executable? I don't see why.
earl-warren commented 2024-03-15 12:51:28 +00:00 (Migrated from code.forgejo.org)
Copy link

I do not think enable cgo is necessary, it should be implicitly set, not explicitly.

I do not think enable cgo is necessary, it should be implicitly set, not explicitly.
👍 1
earl-warren (Migrated from code.forgejo.org) approved these changes 2024-03-15 13:14:10 +00:00
earl-warren commented 2024-03-15 13:14:52 +00:00 (Migrated from code.forgejo.org)
Copy link

It would be great to update the forgejo-pr branch next.

It would be great to update the `forgejo-pr` branch next.
twenty-panda commented 2024-03-17 09:09:52 +00:00 (Migrated from code.forgejo.org)
Copy link

I do not think enable cgo is necessary, it should be implicitly set, not explicitly.

removed

> I do not think enable cgo is necessary, it should be implicitly set, not explicitly. removed
twenty-panda commented 2024-03-17 09:15:23 +00:00 (Migrated from code.forgejo.org)
Copy link

It would be great to update the forgejo-pr branch next.

https://code.forgejo.org/forgejo/end-to-end/pulls/104 is where I'll work on that.

> It would be great to update the `forgejo-pr` branch next. https://code.forgejo.org/forgejo/end-to-end/pulls/104 is where I'll work on that.
Sign in to join this conversation.
Reviewers
No reviewers
earl-warren
Labels
Clear labels   
l1

l1

  
l2
No labels
l1
l2
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: earl-warren/end-to-end#107
No description provided.
Delete branch "refs/pull/107/head"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?